Skip to content

Commit

Permalink
Rel test (#1119)
Browse files Browse the repository at this point in the history
* remove comments

* 8.4.7-rc.31
  • Loading branch information
saikrishna321 authored May 17, 2024
1 parent 97ee631 commit 85cfb0b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 13 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ jobs:
with:
submodules: recursive
token: ${{ secrets.PAT_TOKEN }}
- name: Post bumpr status comment
uses: haya14busa/action-bumpr@v1

# Get tag name.
- id: tag
uses: haya14busa/action-cond@v1
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "appium-device-farm",
"version": "8.4.7-rc.30",
"version": "8.4.7-rc.31",
"description": "An appium 2.0 plugin that manages and create driver session on available devices",
"main": "./lib/src/main.js",
"scripts": {
Expand Down
7 changes: 0 additions & 7 deletions src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ class DevicePlugin extends BasePlugin {
): Promise<void> {
DevicePlugin.httpServer = httpServer;

// cliArgs are here is not pluginArgs yet as it contains the whole CLI argument for Appium! Different case for our plugin constructor
log.debug(`📱 Update server with CLI Args: ${JSON.stringify(cliArgs)}`);
externalModule = await loadExternalModules();
const pluginConfigs = cliArgs.plugin as PluginConfig;
Expand Down Expand Up @@ -164,7 +163,6 @@ class DevicePlugin extends BasePlugin {
DevicePlugin.NODE_ID = uuidv4();
log.info('Cli Args: ' + JSON.stringify(cliArgs));

// I'm transferring the CLI Args to pluginArgs here.
DevicePlugin.nodeBasePath = cliArgs.basePath;

if (pluginArgs.bindHostOrIp === undefined) {
Expand All @@ -187,11 +185,6 @@ class DevicePlugin extends BasePlugin {

registerProxyMiddlware(expressApp, cliArgs, externalModule.getMiddleWares());
externalModule.updateServer(expressApp, httpServer);

// if (!platform)
// throw new Error(
// '🔴 🔴 🔴 Specify --plugin-device-farm-platform from CLI as android,iOS or both or use appium server config. Please refer 🔗 https://github.com/appium/appium/blob/master/packages/appium/docs/en/guides/config.md 🔴 🔴 🔴',
// );
if (hasEmulators && pluginArgs.platform.toLowerCase() === 'android') {
log.info('Emulators will be booted!!');
const adb = await ADB.createADB({});
Expand Down

0 comments on commit 85cfb0b

Please sign in to comment.