Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add server status validation #40

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

mykola-mokhnach
Copy link
Contributor

This would properly short-circuit if the server returns an unexpected status and also improves user-facing massages.

@mykola-mokhnach mykola-mokhnach marked this pull request as ready for review July 9, 2024 14:24
Copy link
Member

@sudharsan-selvaraj sudharsan-selvaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good. The error message is clean and neat👍

src/utils.ts Outdated Show resolved Hide resolved
@saikrishna321 saikrishna321 merged commit 20299df into AppiumTestDistribution:main Jul 10, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
## 1.0.0 (2024-07-10)

### Bug Fixes

* Respect adb settings provided to the driver ([#19](#19)) ([e3a0148](e3a0148))

### Miscellaneous Chores

* Add server status validation ([#40](#40)) ([20299df](20299df))
* setup semantic release ([#41](#41)) ([10a00cb](10a00cb))
* Use logger attached to the driver instance where possible ([#33](#33)) ([639aef8](639aef8))
@saikrishna321
Copy link
Member

saikrishna321 commented Jul 10, 2024

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
## [1.0.3](v1.0.2...v1.0.3) (2024-07-10)

### Miscellaneous Chores

* **release:** 1.0.0 [skip ci] ([8af6ce8](8af6ce8)), closes [#19](#19) [#40](#40) [#41](#41) [#33](#33)
* setup semantic release ([#41](#41)) ([10a00cb](10a00cb))
* **test:** Updated test with byType ([#42](#42)) ([a8b52c2](a8b52c2))
@mykola-mokhnach mykola-mokhnach deleted the status branch July 11, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants