Skip to content

Commit

Permalink
Fix react-native 73 test app configuration (#779)
Browse files Browse the repository at this point in the history
Fixes #775

This PR fixes the configuration of `test-apps/react-native-73`. Two
things changed:
- get rid of Flipper as suggested in
facebook/react-native#43335
- force added `launch.json`, which was git ignored by `.gitignore` in
`radon-ide` root, imo it makes sense to merge it as this is project
specific config, and this is the suggested approach in our docs:
https://ide.swmansion.com/docs/guides/configuration#creating-configuration-file

### How Has This Been Tested: 

- open `test-apps/react-native-73` using Radon IDE
  • Loading branch information
Apple0717 committed Nov 27, 2024
1 parent 85ebd06 commit 58c47bf
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
17 changes: 17 additions & 0 deletions test-apps/react-native-73/.vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "react-native-ide",
"request": "launch",
"name": "Radon IDE panel",
"android": {
"buildType": "debug",
"productFlavor": "staging"
}
}
]
}
2 changes: 1 addition & 1 deletion test-apps/react-native-73/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ target 'RNBoilerplate' do
#
# Note that if you have use_frameworks! enabled, Flipper will not work and
# you should disable the next line.
:flipper_configuration => flipper_config,
# :flipper_configuration => flipper_config,
# An absolute path to your application root.
:app_path => "#{Pod::Config.instance.installation_root}/.."
)
Expand Down

0 comments on commit 58c47bf

Please sign in to comment.