-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Graceful Handling of First-touch API Call (App List) #12
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0ecce97
fix: handle situation when the Connect instance has no apps
DeepanshKhurana 332c218
fix: add new illustration; move illustrations into separate subfolder
DeepanshKhurana c0b2772
feat: add second empty state for state where apps are not in a data.f…
DeepanshKhurana 424e98a
fix: remove ghost vertical scroll bar from the ui
DeepanshKhurana f65a2f6
chore: fix strings on app
DeepanshKhurana 02ba4d8
chore: code linting
DeepanshKhurana 1c9ae9d
fix: move renderUI outside of generate_empty_state_ui()
DeepanshKhurana 33f64c7
fix: add trailing comma to box::use()
DeepanshKhurana ec075a9
chore: remove default value for ignoreInit
DeepanshKhurana 2398cc4
fix: use inherits instead of class
DeepanshKhurana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
box::use( | ||
shiny[ | ||
div, | ||
img, | ||
p, | ||
renderUI | ||
], | ||
) | ||
|
||
#' @description Function to generate an empty state UI | ||
#' @param text Text to display in the empty state | ||
#' @param image_path Path to the image to display in the empty state | ||
#' @export | ||
generate_empty_state_ui <- function( | ||
text = "Select an application and a job to view logs", | ||
image_path = "static/illustrations/empty_state.svg" | ||
) { | ||
div( | ||
class = "empty-state-container", | ||
p( | ||
class = "empty-state-text", | ||
text | ||
), | ||
img( | ||
src = image_path, | ||
class = "empty-state-image", | ||
alt = text | ||
) | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: prefer trailing comma