Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to make Python available as Jupyter Kernel #22

Merged
merged 5 commits into from
Feb 5, 2024
Merged

feat: add ability to make Python available as Jupyter Kernel #22

merged 5 commits into from
Feb 5, 2024

Conversation

koralowiec
Copy link
Member

@koralowiec koralowiec commented Jan 30, 2024 •
edited
Loading

Have you read the Contributing Guidelines?

Issue #

Changes description

Adds ability to make installed Python interpreters available as Jupyter Kernel

@koralowiec koralowiec marked this pull request as ready for review January 31, 2024 08:32
@koralowiec koralowiec requested a review from a team as a code owner January 31, 2024 08:32
@koralowiec koralowiec requested review from edeediong and removed request for a team January 31, 2024 08:33
edeediong
edeediong reviewed Jan 31, 2024
View reviewed changes
Copy link

@edeediong edeediong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the Linter says we should check warning on Line 3. Avoid using paths when importing roles. (../../)

@koralowiec
Copy link
Member Author

I use the path there, because I need to include the role while running converge with molecule
I will check if I can do something with it

edeediong
edeediong approved these changes Feb 1, 2024
View reviewed changes
Copy link

@edeediong edeediong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is running in molecule. So LGTM!

@koralowiec koralowiec merged commit 2e1a809 into main Feb 5, 2024
5 checks passed
@koralowiec koralowiec deleted the feat/jupyter-kernel branch February 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeediong edeediong edeediong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koralowiec @edeediong