-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style box use #114
Style box use #114
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 98.41% 97.99% -0.43%
==========================================
Files 21 22 +1
Lines 821 1046 +225
==========================================
+ Hits 808 1025 +217
- Misses 13 21 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We do not force the trailing comma inside
[]
, it would be great to be able to control this here (e.g. via option). The default should be the same as in the trailing commas linter. - styling functions throw a warning when there is no
box::use
statement (e.g. here)
Nothing to modify in `app/logic/general_utils.R`.
Warning messages:
1: In min(box_lines) : no non-missing arguments to min; returning Inf
2: In max(box_lines) : no non-missing arguments to max; returning -Inf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
box::use()
.box::use()
.# nolint
.box::use()
commands found betweenbox::use()
calls are moved to the top of the fileTechnical notes
treesitter
was used for code parsingsprintf()
instead ofpaste()
orglue::glue()
for performanceDefinition of Done
R CMD check
, linter, unit tests, spelling)..Rd
files withroxygen2::roxygenise()
)