Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo setup #6

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Repo setup #6

merged 11 commits into from
Apr 29, 2024

Conversation

radbasa
Copy link
Collaborator

@radbasa radbasa commented Apr 25, 2024

Issue #5

Description

Preparing the repo for package development

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).

@radbasa radbasa requested a review from jakubnowicki April 25, 2024 03:32
@radbasa radbasa mentioned this pull request Apr 25, 2024
3 tasks
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but please check my comments.

DESCRIPTION Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radbasa radbasa merged commit feb0bed into main Apr 29, 2024
5 checks passed
@radbasa radbasa deleted the repo_setup branch April 29, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants