box_usage_linters for packages

[radbasa]

• Work for Box usage linter #3

extends from PR #8

Changes

Packages

• lints on function not attached
• lints on package$function not exists
• lints on attached function unused
• lints on attached package unused
• lints on invalid function from package box::use(shiny[no_func])
• handles box::use(package[function])
• handles box::use(package)
• handles box::use(package[...])
• handles aliased package functions and aliased packages
• is aware of base packages

Local functions

• lints on declared function unused - may have to remove this. our box modules are libraries of function declarations!
• handles functions declared in source file
• handles internal R6 class object calls

Box modules

• see PR box_usage_linters for modules #10

How to test

Definition of Done

• The change is thoroughly documented.
• The CI passes (R CMD check, linter, unit tests, spelling).
• Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

[jakubnowicki]

LGTM

[jakubnowicki]

I'm not sure how to handle this, but dplyr::desc does not need to be declared in import to work:

box::use(
  dplyr[arrange],
)

mtcars |>
  arrange(desc(mpg))

This will run without any problems...

[radbasa]

I'm not sure how to handle this, but dplyr::desc does not need to be declared in import to work:

box::use(
  dplyr[arrange],
)

mtcars |>
  arrange(desc(mpg))

This will run without any problems...

lintr::lint("test.R", linters = box.linters::box_usage_linter())