Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct Title in DESCRIPTION. #43

Merged
merged 2 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: CI
name: End-to-end tests
on: push
permissions:
contents: read
Expand Down Expand Up @@ -33,12 +33,6 @@ jobs:
run: yarn install
working-directory: e2e_tests

- name: R CMD check
if: always()
uses: r-lib/actions/check-r-package@v2
with:
error-on: '"note"'

- name: Run Cypress
if: always()
uses: cypress-io/github-action@v5
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Type: Package
Package: reactable.extras
Title: Extra Features for 'Reactable' Package
Title: Extra Features for 'reactable' Package
Version: 0.2.0
Authors@R:
c(
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/reactable-server.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,5 @@
<span id="test-page_controls-page_text" class="shiny-text-output"></span>
</div>
</div>
<div class="reactable html-widget html-widget-output shiny-report-size html-fill-item-overflow-hidden html-fill-item" data-reactable-output="test-reactable" id="test-reactable" style="width:auto;height:auto;"></div>
<div class="reactable html-widget html-widget-output shiny-report-size html-fill-item" data-reactable-output="test-reactable" id="test-reactable" style="width:auto;height:auto;"></div>

1 change: 1 addition & 0 deletions tests/testthat/test-reactable-server.R
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ test_that("return_reactable_page should return a reactive page value", {
})

test_that("reactable_extras_ui should return a widget of reactableOutput", {
skip_on_os(c("windows", "mac"))
expect_error(reactable_extras_ui(1))
expect_error(reactable_extras_ui(c("test1", "test2")))
expect_snapshot(reactable_extras_ui("test"))
Expand Down