Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make dropdown work with a singular choice #61

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: make dropdown work with a singular choice #61

merged 2 commits into from
Oct 29, 2024

Conversation

TymekDev
Copy link
Contributor

@TymekDev TymekDev commented Aug 5, 2024

Issue #60

Description

Prior to this change a singular value wasn't serialized as an array. This lead to JS errors when trying to set options.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@TymekDev TymekDev requested a review from jakubnowicki August 5, 2024 13:08
jakubnowicki
jakubnowicki approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubnowicki jakubnowicki merged commit eab4a03 into main Oct 29, 2024
6 checks passed
@jakubnowicki jakubnowicki deleted the 60-fix-single-choice-dropdown branch October 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TymekDev @jakubnowicki