Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Cypress to 13.0.0. #504

Merged
merged 5 commits into from
Oct 25, 2023
Merged

chore: Upgrade Cypress to 13.0.0. #504

merged 5 commits into from
Oct 25, 2023

Conversation

jakubnowicki
Copy link
Member

@jakubnowicki jakubnowicki commented Oct 23, 2023

Upgrade Cypress to v13.

How to test:

  1. Initialize a new Rhino application. Make sure that you have Rhino v1.5.0.9000 installed both globally and in the application.
  2. Run Cypress tests with rhino::test_e2e(interactive = TRUE). Make sure that it uses Cypress 13
  3. Run rhino::test_e2e(interactive = FALSE)

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #504 (6f23a66) into main (7c7793a) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   16.03%   16.03%           
=======================================
  Files           9        9           
  Lines         393      393           
=======================================
  Hits           63       63           
  Misses        330      330           
Files Coverage Δ
R/tools.R 8.53% <ø> (ø)

@jakubnowicki jakubnowicki requested a review from vibalre October 24, 2023 12:01
@jakubnowicki jakubnowicki marked this pull request as ready for review October 24, 2023 12:01
Copy link
Member

@vibalre vibalre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having trouble running the tests locally, so I can't verify the changes.

R/tools.R Outdated Show resolved Hide resolved
R/tools.R Outdated Show resolved Hide resolved
@vibalre
Copy link
Member

vibalre commented Oct 25, 2023

The issues I had with Cypress seems to be with node. I had 18.13. I upgraded to 21.1 and cypress test is working fine.

rhino::test_e2e(interactive = TRUE)
image

image

> rhino::test_e2e()

> test-e2e
> start-server-and-test run-app http://localhost:3333 run-cypress

1: starting server using command "npm run run-app"
and when url "[ 'http://localhost:3333' ]" is responding with HTTP status code 200
running tests using command "npm run run-cypress"


> run-app
> cd .. && Rscript -e "shiny::runApp(port = 3333)"

Loading required package: shiny
Warning: package 'shiny' was built under R version 4.3.1

Listening on http://127.0.0.1:3333

> run-cypress
> cypress run --project ../tests

It looks like this is your first time using Cypress: 13.3.2

[STARTED] Task without title.
[TITLE]  Verified Cypress!       C:\Users\Recle E. Vibal\AppData\Local\Cypress\Cache\13.3.2\Cypress
[SUCCESS]  Verified Cypress!       C:\Users\Recle E. Vibal\AppData\Local\Cypress\Cache\13.3.2\Cypress

Opening Cypress...


DevTools listening on ws://127.0.0.1:60828/devtools/browser/cea72ef8-680d-42f1-82f4-c84b26ef3986

====================================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        13.3.2                                                                         │
  │ Browser:        Electron 114 (headless)                                                        │
  │ Node Version:   v21.1.0 (C:\Program Files (x86)\nodejs\node.exe)                               │
  │ Specs:          1 found (app.cy.js)                                                            │
  │ Searched:       cypress/e2e/**/*.cy.{js,jsx,ts,tsx}                                            │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  app.cy.js                                                                       (1 of 1)

@jakubnowicki jakubnowicki merged commit b032a3c into main Oct 25, 2023
10 checks passed
@jakubnowicki jakubnowicki deleted the upgrade-cypress branch October 25, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants