Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node modules #522

Merged
merged 10 commits into from
Jan 5, 2024
Merged

Upgrade node modules #522

merged 10 commits into from
Jan 5, 2024

Conversation

kamilzyla
Copy link
Collaborator

Changes

This PR is essentialy a refreshed version of #507:

  1. Upgrade all Node modules to latest versions (with the exception of stylelint) and fix vulnerabilities.
  2. Upgrade stylelint to v14. Adjust linter settings & E2E tests as required.
  3. Add migration guide (commit moved from Upgrade node modules #507).

How to test

Initialize a fresh Rhino project and test the Node-based commands (test_e2e(), *_js(), *_sass()).

@kamilzyla kamilzyla requested a review from jakubnowicki January 5, 2024 11:00
jakubnowicki
jakubnowicki approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine 👍

@jakubnowicki jakubnowicki mentioned this pull request Jan 5, 2024
Closed
@kamilzyla kamilzyla merged commit 6926a37 into main Jan 5, 2024
10 checks passed
@kamilzyla kamilzyla deleted the kamil-upgrade-node-modules branch January 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilzyla @jakubnowicki