Box trailing commas linter #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 20.85% 26.91% +6.06%
==========================================
Files 10 10
Lines 422 457 +35
==========================================
+ Hits 88 123 +35
Misses 334 334 ☔ View full report in Codecov by Sentry. |
|
Add argument flag for bracket trailing commas. Default to FALSE. |
* update rhino app template unit test * update e2etest app files * remove what looks like stylr styling
|
* box universal import linter * add box_universal_import_linter to .lintr template * documentation * package housekeeping * removed some lint * namespace box_universal_import_linter * reordered Suggests * update e2etest app files to rhino-box styleguide * address comments/suggestions in PR * fixed version number issue. moved xml2 to imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
box_trailing_commas_linter().lintrtemplatecheck_functions = c(TRUE, FALSE)argument.How to test
box_trailing_commas_linter()existrhino, version should be1.6.0.9002, initialize a new rhino application then proceed to declare box imports.rhino::lint_r()should find and point to all package, module, function imports without a trailing comma.box_trailing_commas_linter = rhino::box_trailing_commas_linter()to.lintr.rhino::lint_r()should find and point to all package, module, function imports without a trailing comma.Known issues
I believe it sees the trailing commas in the example and complains.