-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Box import separate packages modules #542
Box import separate packages modules #542
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
==========================================
+ Coverage 31.64% 34.11% +2.46%
==========================================
Files 10 10
Lines 534 554 +20
==========================================
+ Hits 169 189 +20
Misses 365 365 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter is not able to detect problems if the package imports functions:
box::use(
path/to/module,
package[function1, function2],
)
Fixed.
Added unit tests for aliased modules and functions. Just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
box_separate_calls_linter()
.lintr
templateHow to test
box_separate_calls_linter()
exist.rhino
, version should be1.6.0.9004
, initialize a new rhino application then proceed to declare box imports.box::use()
with both package and modules.rhino::lint_r()
should find and point to the invalidbox::use()
call.