Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom RHINO_NPM command (support bun and pnpm) #549

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Conversation

kamilzyla
Copy link
Collaborator

@kamilzyla kamilzyla commented Jan 17, 2024

Changes

This PR is a copy of #496, rebased onto main and with review suggestions applied. I couldn't edit the PR directly as it's in a forked repository; @nbbn is on sick leave till the end of the week and we don't want to wait (release 1.6 is underway).

How to test

  1. Install npm alternative of your choice, e.g. bun or pnpm. Alternatively, create a simple wrapped-npm script (make it executable and place in your PATH):
    #!/bin/sh
    echo "Wrapper!"
    exec npm "$@"
  2. Run e.g. rhino::lint_js() in a Rhino project. It should use npm by default.
  3. Set RHINO_NPM to the command of your choice and try rhino::lint_js() again. You can do it by running R like this: RHINO_NPM=bun R.

@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (9631c74) 17.82% compared to head (da8256c) 17.73%.

❗ Current head da8256c differs from pull request most recent head 514a762. Consider uploading reports for the commit 514a762 to get more accurate results

Files Patch % Lines
R/node.R 0.00% 15 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   17.82%   17.73%   -0.09%     
==========================================
  Files           9        9              
  Lines         404      406       +2     
==========================================
  Hits           72       72              
- Misses        332      334       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilzyla kamilzyla merged commit 49cff23 into main Jan 18, 2024
28 of 30 checks passed
@kamilzyla kamilzyla deleted the bun-support branch January 18, 2024 17:41
@kamilzyla kamilzyla mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants