-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom RHINO_NPM
command (support bun
and pnpm
)
#549
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 17.82% 17.73% -0.09%
==========================================
Files 9 9
Lines 404 406 +2
==========================================
Hits 72 72
- Misses 332 334 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
This PR is a copy of #496, rebased onto
main
and with review suggestions applied. I couldn't edit the PR directly as it's in a forked repository; @nbbn is on sick leave till the end of the week and we don't want to wait (release 1.6 is underway).How to test
npm
alternative of your choice, e.g.bun
orpnpm
. Alternatively, create a simplewrapped-npm
script (make it executable and place in yourPATH
):rhino::lint_js()
in a Rhino project. It should usenpm
by default.RHINO_NPM
to the command of your choice and tryrhino::lint_js()
again. You can do it by running R like this:RHINO_NPM=bun R
.