Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove observeEvent anti-pattern from docs #554

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Conversation

alexverse
Copy link
Contributor

@alexverse alexverse commented Jan 31, 2024

Updates documentation to avoid observeEvent anti-pattern, and simplifies reactive graphs.

Changes

  • How-to Vignette: Communication between modules
  • How-to Vignette: Use global variables

@alexverse alexverse requested a review from kamilzyla January 31, 2024 19:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d3662f) 17.73% compared to head (b6432d7) 17.73%.

❗ Current head b6432d7 differs from pull request most recent head 86aa6a8. Consider uploading reports for the commit 86aa6a8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   17.73%   17.73%           
=======================================
  Files           9        9           
  Lines         406      406           
=======================================
  Hits           72       72           
  Misses        334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kamilzyla kamilzyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexverse for spotting this and submitting a fix! 🙏

While reviewing your PR I noticed some pre-existing issues in the examples, e.g.:

  1. table_module = app/view/table_module.R in box::use(), where table_module = is unnecessary and .R is forbidden.
  2. A reactive that contains that the data (delete that).
  3. The utils.R module is not defined. It would be nice to have a simple mock module defined, so that one could copy-paste the examples into a Rhino app and run it.

Perhaps you're up for addressing these as well (in this or a different PR)?

vignettes/how-to/communicate-between-modules.Rmd Outdated Show resolved Hide resolved
@alexverse
Copy link
Contributor Author

Thank you @kamilzyla. I will address the other issues you mentioned in a subsequent PR.

@alexverse alexverse merged commit d9da2b0 into Appsilon:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants