Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add box.lsp integration #612

Merged
merged 32 commits into from
Sep 5, 2024
Merged

Add box.lsp integration #612

merged 32 commits into from
Sep 5, 2024

Conversation

radbasa
Copy link
Contributor

@radbasa radbasa commented Sep 3, 2024 •
edited
Loading

Branched from PR #607. Waiting for box.linters 0.10.4 fixes.

Closes #613

Description

  • Adds box.lsp to .Rprofile
  • Adds documentation about box::use auto-complete

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

radbasa added 17 commits August 5, 2024 14:40
@radbasa radbasa changed the base branch from main to integrate-box-linters-styling September 3, 2024 09:11
@radbasa radbasa requested a review from jakubnowicki September 4, 2024 08:58
jakubnowicki
jakubnowicki reviewed Sep 4, 2024
View reviewed changes
vignettes/how-to/box-lsp.Rmd Outdated Show resolved Hide resolved
pkgdown/_pkgdown.yml Outdated Show resolved Hide resolved
Base automatically changed from integrate-box-linters-styling to main September 5, 2024 04:07
jakubnowicki
jakubnowicki approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radbasa radbasa merged commit 78dfe9b into main Sep 5, 2024
10 checks passed
@radbasa radbasa deleted the integrate-box-lsp branch September 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate box.lsp for box module autocomplete
2 participants
@radbasa @jakubnowicki