Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Breadcrumbs and more #16

Merged
merged 10 commits into from
Jun 22, 2022
Merged

Add Breadcrumbs and more #16

merged 10 commits into from
Jun 22, 2022

Conversation

kamilzyla
Copy link
Collaborator

@kamilzyla kamilzyla commented Jun 15, 2022

Changes

Add the following components:

  1. Breadcrumbs
  2. OverflowList
  3. PanelStack2 - Also created Design a better interface for PanelStack2 #14, as the component is challenging to use from R.
  4. ResizeSensor
  5. Label
  6. Checkbox, Checkbox.shinyInput
  7. Radio, RadioGroup, RadioGroup.shinyInput

Removed TODOs for:

  1. Skeleton: Not a component, just a CSS class.
  2. CollapsibleList: Deprecated in favor of OverflowList.

How to test

Run and review examples for the new components. Check if the spreadsheet is updated accordingly.

@kamilzyla kamilzyla requested a review from filipakkad June 15, 2022 08:50
@kamilzyla kamilzyla self-assigned this Jun 15, 2022
transform: translate(-50%, -50%);
}
"),
tags$script(HTML("(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's big :D (I've the issue you've submited).

Copy link
Contributor

@filipakkad filipakkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added two comments, LGTM

@kamilzyla kamilzyla merged commit 0c1bea3 into main Jun 22, 2022
@kamilzyla kamilzyla deleted the breadcrumbs-and-more branch June 22, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants