fixed dropdown when multiple inputs are needed #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/dropdown.R
Outdated
| if (!is.null(value)) value <- paste(as.character(value), collapse = ",") | ||
| if (!is.null(value)) { | ||
| value <- paste(as.character(value), collapse = ",") | ||
| value <- paste0(value, ",") |
There was a problem hiding this comment.
@dokato why this change solves an issue?
There was a problem hiding this comment.
I think this is due to how the split works in JS: https://github.com/Appsilon/shiny.semantic/blob/develop/inst/www/shiny-semantic-dropdown.js#L28 otherwise it is not treated as an array.
|
@dokato I think that the fix should be done in a different place. It looks like javascript needs to be updated to treat a single value correctly instead of hacking in an empty value as a second argument in R. |
|
Thank you for the fix @krystian8207, works well. As a note: Fomantic automatically sets the 'active' class so it is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308 .
Contributes to #313
A bit hacky, but this should help.
DoD
Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.
Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.
No new error or warning messages are introduced.
All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.
If the change affects code or repo sctructure, README, documentation and code comments should be updated.
All code has been peer-reviewed before merging into any main branch.
All changes have been merged into the main branch we use for development (develop).
Continuous integration checks (linter, unit tests) are configured and passed.
Unit tests added for all new or changed logic.
All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.
Any added or touched code follows our style-guide.