Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation #389

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Conversation

ashbaldry
Copy link
Contributor

@ashbaldry ashbaldry commented Oct 24, 2021

Adding the ability to validate input fields in a form.

Resolves #386

DoD

  • Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.

  • Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.

  • No new error or warning messages are introduced.

  • All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.

  • If the change affects code or repo sctructure, README, documentation and code comments should be updated.

  • All code has been peer-reviewed before merging into any main branch.

  • All changes have been merged into the main branch we use for development (develop).

  • Continuous integration checks (linter, unit tests) are configured and passed.

  • Unit tests added for all new or changed logic.

  • All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.

  • Any added or touched code follows our style-guide.

@ashbaldry
Copy link
Contributor Author

Hi @esraay,
I've seen a couple of updates to my PRs, thanks for that! I have made more updates to this one (including a small vignette) in a separate package {fomantic.plus}. If you would prefer, instead of having the two separate versions, I can add these updates to this branch and just keep {shiny.semantic} maintained.

@scizmeli
Copy link
Contributor

Hi @ashbaldry thanks for your input. As a new team we started to give shiny.semantic regular maintenance. It would be a good idea to submit your vignette for Appsilon's reviewal and keep as much as possible in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Validation
4 participants