Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release]: 0.2.0 #141

Merged
merged 10 commits into from
Nov 15, 2023
Merged

[Release]: 0.2.0 #141

merged 10 commits into from
Nov 15, 2023

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Sep 28, 2023

Release checklist:

  • Run desc::normalize() to normalize DESCRIPTION file
  • Make sure all CI actions are green
  • Build the package locally using the command:R CMD build . which will generate a .tar.gz file necessary for the CRAN submission.
    • Ceate a git tag called X.X.X-rcX with the build
  • Submit the package that was build in the previous step via this form: https://cran.r-project.org/submit.html
  • Address CRAN feedback and repeat the submission to CRAN whenever necessary
  • Create a git tag with the final version set to X.X.X on the main branch

Changes description

  • Updates version to 0.2.0 (DESCRIPTION & NEWS.md)
  • Added related PRs to NEWS.md items
  • Call desc::normalize() to cleanup DESCRIPTION (sorts fields and packages in a standard way)
  • Removed unused packages from Suggests
    • {here}, {mockery} were not used in {shiny.telemetry}
      • ({here} is used inside plumber, but that included in its renv.lock)
    • {covr}, {lintr}, {spelling}, {rcmdcheck} were necessary for a Mac OS GH action
      • moved their installation to the setup-r step of the workflow (as per the documentation of the workflow)
    • {stringr} was used once and it's easily replaced
  • Added triple dash prefix to yaml files
    • Signals start of the document
  • Reduced workflow trigger for prepare-connect workflow
    • Trigger only on PRs and push to main

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment. Besides that, windevel-check spotted this:

Found the following (possibly) invalid file URI:
  URI: ./CONTRIBUTING.md
    From: README.md

Note that CONTRIBUTING.md is in .Rbuildignore.

DESCRIPTION Show resolved Hide resolved
@averissimo averissimo changed the title [Release]: 0.1.1 [Release]: 0.2.0 Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #141 (70a829a) into main (725a97b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 70a829a differs from pull request most recent head 3a14e01. Consider uploading reports for the commit 3a14e01 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   31.16%   31.16%           
=======================================
  Files          16       16           
  Lines        1428     1428           
=======================================
  Hits          445      445           
  Misses        983      983           
Files Coverage Δ
R/auxiliary.R 97.87% <100.00%> (ø)

@averissimo
Copy link
Contributor Author

@jakubnowicki I've solved your comments and did a bit of house cleaning.

House cleaning:

  • Added related PRs to NEWS.md items
  • Call desc::normalize() to cleanup DESCRIPTION (sorts fields and packages in a standard way)
  • Removed unused packages from Suggests
    • {here}, {mockery} were not used in {shiny.telemetry}
      • ({here} is used inside plumber, but that included in its renv.lock)
    • {covr}, {lintr}, {spelling}, {rcmdcheck} were necessary for a Mac OS GH action
      • moved their installation to the setup-r step of the workflow (as per the documentation of the workflow)
    • {stringr} was used once and it's easily replaced
  • Added triple dash prefix to yaml files
    • Signals start of the document
  • Reduced workflow trigger for prepare-connect workflow
    • Trigger only on PRs and push to main

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/check_with_databases.yml Show resolved Hide resolved
@averissimo averissimo merged commit dd4b4d4 into main Nov 15, 2023
8 checks passed
@averissimo averissimo deleted the cran_release_0.1.1 branch November 15, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants