-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release]: 0.2.0 #141
[Release]: 0.2.0 #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment. Besides that, windevel-check spotted this:
Found the following (possibly) invalid file URI:
URI: ./CONTRIBUTING.md
From: README.md
Note that CONTRIBUTING.md
is in .Rbuildignore
.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 31.16% 31.16%
=======================================
Files 16 16
Lines 1428 1428
=======================================
Hits 445 445
Misses 983 983
|
@jakubnowicki I've solved your comments and did a bit of house cleaning. House cleaning:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Release checklist:
desc::normalize()
to normalize DESCRIPTION fileX.X.X-rcX
with the buildChanges description
DESCRIPTION
&NEWS.md
)NEWS.md
itemsdesc::normalize()
to cleanupDESCRIPTION
(sorts fields and packages in a standard way)Suggests
{here}
,{mockery}
were not used in{shiny.telemetry}
{here}
is used inside plumber, but that included in itsrenv.lock
){covr}
,{lintr}
,{spelling}
,{rcmdcheck}
were necessary for a Mac OS GH action{stringr}
was used once and it's easily replacedyaml
filesprepare-connect
workflowmain