Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem when log_all_inputs is called manually #189

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Aug 5, 2024

Closes #187 and #188

Changes description

  1. Fixes bug with log_all_inputs
  2. Adds log_errors method
  3. Fixes analytics app

How to test?

  1. Run example app on [Bug]: Telemetry$log_all_inputs() method crashes app with "argument "track_errors" is missing, with no default" error message #187
  2. (internal, making sure that errors are being logged)
  3. Run sample app and then ppen analytics app that doesn't have any logged error
    • Click on session tab
    • Click on any session (that doesn't have error)
    • (visual guide below)

Error on deployed app

image

Fixed in this PR (error + annotation)

image

Definition of done

  • Have you read the Contributing Guidelines?
  • NEWS.md file has been updated
  • Development version has been bumped (x.y.z.90XX)
  • Issue has been linked with this PR (via Closing keywords or right sidebar under Development)

@averissimo
Copy link
Contributor Author

averissimo commented Aug 7, 2024

@f-meister can you review this PR? 🙇

It should fix your issue and another one with the analytics app. I provided with some extra comments for additional context.

Copy link
Contributor

@WahiduzzamanKhan WahiduzzamanKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my testing, the errors are resolved.
I also do not see anything that looks odd or out of place.

@averissimo averissimo merged commit 06b89f1 into main Oct 9, 2024
9 checks passed
@averissimo averissimo deleted the 187-fix-log_all_inputs branch October 9, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants