Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotificationBlock: Refactor to mirror Postblock #1661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Dec 9, 2024

Description

We've gone back and forth over this, haven't we?

This switches NotificationBlock's method of selecting which elements are hidden from a CSS selector containing all of the relevant post (root) ids to javascript logic that determines whether to apply a single attribute. This:

This may wind up as just a commit in another PR. In general, there's a tension between the order of things that minimizes merge conflicts and that which reduces review, probably, but I'm imho really good at managing merge conflicts at this point so ultimately makes no difference.

Testing steps

Confirm that NotificationBlock continues to function as normal, including updates to the shown/hidden state of onscreen notifications when blocking/unblocking (e.g. from the blog view modal on the activity page).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant