Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeformat: Apply to new communities post header #1693

Merged

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jan 9, 2025

Description

Applies timeformat to the timestamps in the new unique post header used in tumblr communities (communitiesRedpopPostChrome).

Not sure if this will break anything else, like mutual checker yes it does.

Is this actually... desirable? I mean, I assume so, though the aesthetics aren't great.

Testing steps

  • Confirm that Timeformat works on community posts with the new header (feature flag enabled).

@marcustyphoon
Copy link
Collaborator Author

Ah, this might become more relevant than I realized.

@AprilSylph
Copy link
Owner

This is introducing some unnecessary height to the post header as-is... gonna see if I can fix it.

* update font size
* fix extra height added by pseudo-elements
* allow whole subheader to wrap if necessary
@AprilSylph
Copy link
Owner

Flex items being their own display type is so weird, always throws me off.

I'm gonna merge this now, but just to let you know, I am aware of this fuckass behaviour and will fix it with a Tumblr-side change in the coming week:

Screen Shot 2025-03-02 at 20 10 15

(The separator needs to stop being on the .timestamp::before and instead be its own element inside the .info so that it disappears when .info is collapsed to a width of zero, but that also means it will stay at the end of the line when we allow wrapping via the CSS I just committed here.)

@AprilSylph AprilSylph merged commit 53b699e into AprilSylph:master Mar 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants