Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessKit Disable GIFs: Blur animated images while processing #1721

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Feb 8, 2025

Description

Fun bit of CSS experimentation. This applies a temporary blur effect to images with GIF backgrounds that will be animated only for a moment while we're processing them. Like #1128 and #960, care is taken not to apply the effect when the extension is first loaded or the feature is switched on to avoid an unblurred -> blurred -> unblurred chain. Not sure this is really any better than not doing it, but it's cute.

Have you heard of the contain CSS property? I sure hadn't.

Branch based off of #1729.

Testing steps

@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Feb 9, 2025

This was supposed to be a just for fun thing, but, like... I really like it actually? :D But I think CSS blurs can perform really badly on older hardware, so my guess is it's too risky.

edit: Although Tumblr does use them in the Tumblr Premium modal and in the settings page when you click to edit your password (and used to(?) on "blurred" mature posts)... so maybe it's fine?

edit: This branch has been updated to be based on newer code, which (on sufficiently new browsers) pauses background-gif images more quickly by streaming the image response. At least on my internet connection, this makes this almost entirely pointless, as I hardly get a chance to see the blurred elements before they're paused.

@marcustyphoon marcustyphoon force-pushed the disable-gifs-pause-background-blur branch 11 times, most recently from e9ed8ca to e566158 Compare February 18, 2025 09:13
@marcustyphoon marcustyphoon force-pushed the disable-gifs-pause-background-blur branch from e566158 to ae9062b Compare February 18, 2025 09:29
@marcustyphoon marcustyphoon force-pushed the disable-gifs-pause-background-blur branch 14 times, most recently from 8198929 to 1b211b6 Compare February 19, 2025 12:36
@marcustyphoon marcustyphoon force-pushed the disable-gifs-pause-background-blur branch 8 times, most recently from 2cdf5c1 to 0ca3c63 Compare February 21, 2025 01:40
@marcustyphoon marcustyphoon force-pushed the disable-gifs-pause-background-blur branch from 0ca3c63 to 60c22c0 Compare February 21, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant