Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessKit Disable GIFs: Fix unstretched photoset hover area #1730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Feb 18, 2025

Description

Sufficiently-narrow images are not stretched horizontally to the post container width on desktop Tumblr. This fixes a minor issue with our current code where the hover-to-animate area of a disabled unstretched GIF included the blank space to its right and any adjacent non-animated images, because we were processing them as if they're part of a photoset.

Note that at time of writing I left a bug in this: resizing the viewport across the desktop <-> tablet boundary in either direction results in slightly unintended photoset hover behavior, though it's no worse than before. If anyone can think of an elegant fix, be my guest, but otherwise, eh, I doubt anyone will notice.

Testing steps

@marcustyphoon marcustyphoon added the bugfix Restores intended behavior label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant