Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Build Configuration and Resolve Compatibility Issues #332

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Update Build Configuration and Resolve Compatibility Issues #332

merged 2 commits into from
Dec 9, 2024

Conversation

eslamwael74
Copy link
Contributor

@eslamwael74 eslamwael74 commented Dec 7, 2024 •
edited
Loading

  • Added the Android namespace to resolve the missing namespace issue on Gradle version 8.x.x and above.
  • Updated the compileSdk to version 34 for compatibility with the latest Android API.
  • Removed the deprecated compileSdkVersion to align with modern Gradle practices.
  • Adjusted the path for generated resources to reference the correct location in the tools SDK.

@NoftScarlet
Copy link

Hey Shirley @sgong-pdftron and Andrew @ama-pdftron, could you please take a look when you have a moment?
Somewhat related to #329

@brandenfung2
Copy link
Contributor

Looks good to me. Thanks for the PR!

@brandenfung2 brandenfung2 merged commit 06b4e74 into ApryseSDK:master Dec 9, 2024
1 check failed
@brandenfung2 brandenfung2 mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eslamwael74 @NoftScarlet @brandenfung2