Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed FsObject error message to avoid recursion #68

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Aug 15, 2024

when raising a FormatMismatchError, FsObject recursively attempts to print itself to a string

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.44%. Comparing base (a9a3715) to head (81a652e).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
fileformats/generic/fsobject.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   92.46%   92.44%   -0.02%     
==========================================
  Files          43       43              
  Lines        5041     5042       +1     
  Branches      553      554       +1     
==========================================
  Hits         4661     4661              
- Misses        286      287       +1     
  Partials       94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 04fa1a4 into main Sep 4, 2024
16 of 17 checks passed
@tclose tclose deleted the fs-object-bug-fix branch September 5, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant