feat: eventfd crate & syscall #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binary-bruce
force-pushed
the
crate-eventfd
branch
6 times, most recently
from
363b2b5 to
5ca6612
Compare
binary-bruce
commented
May 9, 2024
| use core::convert::{From, Into}; | ||
| use core::option::Option; | ||
| use core::option::Option::{None, Some}; | ||
| use core::prelude::rust_2021::derive; |
There was a problem hiding this comment.
not sure why does the clippy ask me to import the above
Azure-stars
reviewed
May 9, 2024
There was a problem hiding this comment.
- If you has split the eventfd as a indendpent crate, then codes about this crate in
ulib/axstarry/src/syscall_fsmodule may be updated to remove useless code. - Maybe you need to squash your commit, for example the commit reorder
binary-bruce
force-pushed
the
crate-eventfd
branch
from
5ca6612 to
851b291
Compare
Hi @Azure-stars
Thanks. |
binary-bruce
force-pushed
the
crate-eventfd
branch
from
65d93da to
c064f07
Compare
Azure-stars
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the eventfd logic(reusable part) to crates to make the code more testable and composable.
Test evidence:
riscv
x86_64
