add sys_dup2 and sys_dup3 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure-stars
reviewed
May 31, 2024
| @@ -7,6 +7,7 @@ use alloc::sync::Arc; | |||
| use alloc::vec; | |||
| use axerrno::AxError; | |||
| use axfs::api::{FileIOType, OpenFlags, SeekFrom}; | |||
| use axlibc::ctypes; | |||
There was a problem hiding this comment.
Axlibc is the posix compatibility layer for Unikernel, and it don't update for a long time. The new type for syscall can be defined in axstarry/src/syscall_fs/ctype.rs
Azure-stars
approved these changes
May 31, 2024
| @@ -4,6 +4,8 @@ use axhal::{ | |||
| }; | |||
| use bitflags::*; | |||
| use core::panic; | |||
| /// a flag used in sys_dup3 | |||
There was a problem hiding this comment.
You can wrap the flags as a full type for dup3 syscall in the next commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current syscall_dup3 is actually syscall_dup2, change syscall_dup3 to syscall_dup2 and add syscall_dup3.