LTTP: Update to options API

[nicholassaylor]

What is this fixing or adding?

• Updates options calls to use the appropriate access API.
• per_slot_randoms were elimated in the code
• In various spots, instances of world: Multiworld, explicit or implied were eliminated (Will be moved to another PR)

This would "supercede" #3764 and #3763
Also would solve concerns in #3382 and #3284

How was this tested?

Running all unittests
Running Generate with seed=1 and comparing patch files and spoiler logs

[NewSoupVi]

There are a couple instances of world.swordless[player] that were missed.

[NewSoupVi]

In Rom.py line, an instance of world.glitches_required[player] was missed.

[NewSoupVi]

In Rom.py line, an instance of world.glitches_required[player] was missed.

Wow, I was tired earlier, sorry for making you go look for it :D

[nicholassaylor]

In Rom.py line, an instance of world.glitches_required[player] was missed.

Wow, I was tired earlier, sorry for making you go look for it :D

I was able to piece together what you meant. It helped that it was in the screenshot.

[NewSoupVi]

That's everything I could find.

[NewSoupVi]

Looked at every line to find potential errors - They were addressed
Did randomized test generations to catch more errors - They were addressed
Verified that any remaining generations crashes I ran into happen on the old version as well.

Did not compare outputs of successfully generating seeds, that's something another peer review could maybe do.

This is a peer review approval, not a core review approval.

[Exempt-Medic]

I have not looked at the code, but I grabbed main and this and compared the spoiler logs of a two-player ALttP gen with fully-random yamls for seeds 1-50. Not exactly "good" testing, but they were identical outside of playthrough and traversal

[Exempt-Medic]

Tested these changes with these changes. Tests passed.

• Core, all worlds: Hard-deprecate old options API (by August 10th 2024) #3284
• Core: hard deprecate per_slot_randoms #3382

[Exempt-Medic]

Looked at the code, guess my 50 random tests was definitely not enough

[nicholassaylor]

I believe that I covered everything that was requested.

[Exempt-Medic]

Peer Review, I suppose. My requested changes were made, the errors I found were fixed. Compared outputs of different generations, but either did not hit the few errors I found or they were not relevant. Searched through all the changes for ".value" to see any asymmetric changes and did not find any.