Launcher: ports the _stop fix in the Launcher kivy App to handle_url Popup App #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er kivy app like text client
github-actions
bot
added
affects: core
Exempt-Medic
added
the
is: bug/fix
NewSoupVi
approved these changes
Nov 21, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
…Popup App (ArchipelagoMW#4213) * fixes url launched popup so it can close cleanly after spawning another kivy app like text client * whoops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
When handling a url for a game that has a url-handling component (ex.
launcher.py "archipelago://test:@localhost?game=The Messenger") the popup gives you an option between text client and game-specific component, staying open to allow the user to open both if desiredThe issue is if you open a Kivy app (like text client) with that popup closing the popup window without closing all the spawned kivy apps will cause the popup to go unresponsive
This just ports the _stop override in the Launcher App definition to the Popup App definition which fixes the above issue.
How was this tested?
by doing above steps and seeing it act like I expect it to
If this makes graphical changes, please attach screenshots.