Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: clean up create_item/event example #4596

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

qwint
Copy link
Collaborator

@qwint qwint commented Feb 2, 2025

What is this fixing or adding?

it wasn't right

How was this tested?

it's right now

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 2, 2025
docs/world api.md Outdated Show resolved Hide resolved
Copy link
Contributor

@BootsinSoots BootsinSoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes do not affect code. Works

Copy link

@Rooby-Roo Rooby-Roo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was the person who originally ran into this issue. This change now makes the example code work.

@qwint qwint added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 11, 2025
@NewSoupVi NewSoupVi merged commit b2162bb into ArchipelagoMW:main Feb 12, 2025
3 checks passed
@qwint qwint deleted the docs_progression_events branch February 12, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants