WebHost: Add Select All checkbox for OptionSets #4619
+48
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
Exempt-Medic
added
the
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds a Select All checkbox for OptionSets, underneath the title. The checkbox is tri-state: Checked when clicked, Unchecked when clicked again, and Indeterminate when a member checkbox of the corresponding OptionSet is clicked. Naturally, clicking the Select All checkbox automatically sets all member checkboxes to Checked, clicking it again automatically sets them all to Unchecked. When Export Options is clicked, this element is filtered out of the YAML keys, so the YAML only retains the member checkbox values.
Looking for feedback - I threw this together in only a couple hours and with some quick input from qwint and Kaito.
How was this tested?
Ran WebHost locally, used Muse Dash options and generated several YAMLs. I tested all three states and reviewed the YAMLs looking for the name of the checkbox. I also generated a seed right from the options page and got a room created with no issue. I did not actually connect to the room.
If this makes graphical changes, please attach screenshots.
Video