Upgrade html5lib to 1.0.1 #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tokenizer was never part of the official API. Minimal changes to get wpull running with html5lib==1.0.1.
|
How does this affect the performance? I believe the main reason for using only the |
|
I would not worry about that right now. The bigger issue is imo that this change breaks XML/RSS parsing and that the parsing code itself is quite fragile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tokenizer module was never part of html5lib’s public interface and has consequently been made private in recent versions. This breaks wpull’s HTML scraper. This pull request contains a minimally invasive change, adding support for html5lib=1.0.1. A proper solution would extend TreeWalker to yield wpull’s tag stream directly.
Abusing html5lib to parse XML/RSS is not possible any more and yields incorrect tag streams (tag text is considered the tail of the closing tag). Thus, this change breaks test_rss_as_html and possibly other tests.
Please do not merge this proof of concept until the issues mentioned above are resolved.