Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert multi payment amount #1163

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

alfonsobries
Copy link
Contributor

Summary

https://app.clickup.com/t/86dvrv22k

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley
Copy link
Member

@alfonsobries there seems to be a failing test which (i suspect) is related to your changes

@alexbarnsley alexbarnsley marked this pull request as draft January 22, 2025 14:54
@alfonsobries
Copy link
Contributor Author

@alexbarnsley fixed

@alfonsobries alfonsobries marked this pull request as ready for review January 22, 2025 15:18
Copy link
Member

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR recipient amount needs to be shown in wei I think

@alexbarnsley alexbarnsley marked this pull request as draft January 22, 2025 17:04
@alexbarnsley alexbarnsley marked this pull request as ready for review January 23, 2025 23:38
@alexbarnsley alexbarnsley merged commit a53eb90 into mainsail-develop Jan 23, 2025
14 checks passed
@alexbarnsley alexbarnsley deleted the fix/convert-multi-payment-amount branch January 23, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants