Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false positive recent votes tests #1166

Merged
merged 36 commits into from
Jan 27, 2025
+109 −86
Merged

fix: false positive recent votes tests #1166

Changes from 32 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
193a07a
feat: reintegrate username functionality
alexbarnsley Dec 18, 2024
39d6eb5
Merge remote-tracking branch 'origin/mainsail-develop' into feat/rein…
alexbarnsley Jan 8, 2025
a879732
add username to addressing table cell
alexbarnsley Jan 8, 2025
45595d4
additional reverted changes
alexbarnsley Jan 8, 2025
cd6f5c5
test
alexbarnsley Jan 8, 2025
481b9c5
test
alexbarnsley Jan 8, 2025
c78cb19
forget resigned usernames
alexbarnsley Jan 9, 2025
3b74745
fix formatting of wallet search username
alexbarnsley Jan 9, 2025
5cc519a
add missing hasUsername methods
alexbarnsley Jan 9, 2025
4b338a4
fix formatting of wallet search username
alexbarnsley Jan 9, 2025
1241924
test
alexbarnsley Jan 9, 2025
9cfd03f
remove unnecesary iconless component & corresponding methods
alexbarnsley Jan 9, 2025
807e1be
test
alexbarnsley Jan 9, 2025
e3eed28
style: resolve style guide violations
alexbarnsley Jan 9, 2025
6138711
chore: stanley
alexbarnsley Jan 9, 2025
e42f078
Merge branch 'feat/reintegrate-username-functionality' of github.com:…
alexbarnsley Jan 9, 2025
da93909
Merge branch 'mainsail-develop' into feat/reintegrate-username-functi…
alexbarnsley Jan 9, 2025
1c511c7
Merge branch 'mainsail-develop' into feat/reintegrate-username-functi…
alexbarnsley Jan 15, 2025
a175c9d
test
alexbarnsley Jan 15, 2025
9e7912c
style: resolve style guide violations
alexbarnsley Jan 15, 2025
379afa6
test wallet controller for username
alexbarnsley Jan 16, 2025
b2557c7
Merge branch 'mainsail-develop' into feat/reintegrate-username-functi…
alfonsobries Jan 16, 2025
deaa74f
Merge remote-tracking branch 'origin/mainsail-develop' into feat/rein…
alexbarnsley Jan 16, 2025
c1b73b7
remove duplicate address entry
alexbarnsley Jan 16, 2025
760eec0
Merge branch 'mainsail-develop' into feat/reintegrate-username-functi…
ItsANameToo Jan 17, 2025
122db1d
improve tx sort by username
alexbarnsley Jan 21, 2025
94fdb19
consolidate username method to always show known first
alexbarnsley Jan 21, 2025
ec705bd
keep null values last in sorting & add tests
alexbarnsley Jan 22, 2025
13d31d0
Merge remote-tracking branch 'origin/mainsail-develop' into feat/rein…
alexbarnsley Jan 22, 2025
a24af42
fix: false positive recent votes tests
alexbarnsley Jan 22, 2025
2ab675d
style: resolve style guide violations
alexbarnsley Jan 22, 2025
46a8bce
Merge remote-tracking branch 'origin/mainsail-develop' into fix/false…
alexbarnsley Jan 24, 2025
d4d26bb
remove unnecessary id column on mocked wallets table
alexbarnsley Jan 24, 2025
c1ab6db
adjust sort by address criteria
alexbarnsley Jan 24, 2025
2023a5d
enforce values for transactions in tests
alexbarnsley Jan 24, 2025
2e5ca75
style: resolve style guide violations
alexbarnsley Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 90 additions & 71 deletions tests/Feature/Http/Livewire/Validators/RecentVotesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,15 @@ function generateTransactions(): array
->assertSet('sortKey', 'age')
->assertSet('sortDirection', SortDirection::DESC)
->assertSeeInOrder([
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,

'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
]);
});

Expand All @@ -255,41 +260,15 @@ function generateTransactions(): array
->call('sortBy', 'age')
->assertSet('sortDirection', SortDirection::ASC)
->assertSeeInOrder([
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
]);
});

it('should sort name in ascending order', function () {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a new test so these were no longer needed

$data = generateTransactions();

Livewire::test(RecentVotes::class)
->call('setIsReady')
->call('sortBy', 'name')
->assertSet('sortDirection', SortDirection::ASC)
->assertSeeInOrder([
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
]);
});

it('should sort name in descending order', function () {
$data = generateTransactions();

Livewire::test(RecentVotes::class)
->call('setIsReady')
->call('sortBy', 'name')
->call('sortBy', 'name')
->assertSet('sortDirection', SortDirection::DESC)
->assertSeeInOrder([
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,

'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
]);
});

Expand All @@ -301,10 +280,15 @@ function generateTransactions(): array
->call('sortBy', 'address')
->assertSet('sortDirection', SortDirection::ASC)
->assertSeeInOrder([
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,

'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
]);
});

Expand All @@ -317,10 +301,15 @@ function generateTransactions(): array
->call('sortBy', 'address')
->assertSet('sortDirection', SortDirection::DESC)
->assertSeeInOrder([
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,

'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
]);
});

Expand All @@ -332,10 +321,15 @@ function generateTransactions(): array
->call('sortBy', 'type')
->assertSet('sortDirection', SortDirection::ASC)
->assertSeeInOrder([
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,

'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
]);
});

Expand All @@ -348,10 +342,15 @@ function generateTransactions(): array
->call('sortBy', 'type')
->assertSet('sortDirection', SortDirection::DESC)
->assertSeeInOrder([
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,

'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
]);
});

Expand Down Expand Up @@ -401,18 +400,28 @@ function generateTransactions(): array

$this->get('/test-validators?sort=type&sort-direction=asc')
->assertSeeInOrder([
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,

'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
]);

$this->get('/test-validators?sort=type&sort-direction=desc')
->assertSeeInOrder([
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,

'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
]);
});

Expand All @@ -425,18 +434,28 @@ function generateTransactions(): array

$this->get('/test-validators?sort=type&sort-direction=desc')
->assertSeeInOrder([
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,

'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
]);

$this->get('/test-validators?sort=type&sort-direction=testing')
->assertSeeInOrder([
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
$data['unvoteTransaction']->address,
$data['voteTransaction']->address,
'vote-item*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-item*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,

'vote-mobile*'.$data['voteTransaction']->id,
$data['voteTransaction']->id,
'vote-mobile*'.$data['unvoteTransaction']->id,
$data['unvoteTransaction']->id,
]);
});

Expand Down
Loading