Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate webpack mix to vite #857

Merged
merged 42 commits into from
Apr 25, 2024

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Apr 23, 2024

Summary

https://app.clickup.com/t/86dt259z5

Based off of #856 to save on worrying about package differences/changes

Requires ArkEcosystem/laravel-foundation#615

TODO:

  • Fix missing logo
  • Update GitHub Workflows
  • phpstan unknown assets method
  • Devtools sortBy error on Exchanges page
  • Tests failing looking for Mix manifest.json

To test:

  • Add VITE_HOST=arkscan-2.test to .env
  • Run development mode pnpm dev
  • Run build pnpm build

For HTTPS, it's setup to use valet currently:

  • valet secure
  • update APP_URL to have https (may not be needed but worth doing)

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@github-actions github-actions bot added the chore label Apr 23, 2024
@alexbarnsley alexbarnsley changed the base branch from develop to chore/use-pnpm-instead-of-yarn April 23, 2024 19:01
@alexbarnsley alexbarnsley force-pushed the refactor/migrate-webpack-mix-to-vite branch from 7d23639 to 02f6150 Compare April 23, 2024 19:04
@alexbarnsley alexbarnsley reopened this Apr 23, 2024
@ItsANameToo ItsANameToo changed the title chore: use pnpm instead of yarn chore: migrate from Laravel mix to vite Apr 24, 2024
@alexbarnsley alexbarnsley changed the title chore: migrate from Laravel mix to vite refactor: migrate webpack mix to vite Apr 24, 2024
Base automatically changed from chore/use-pnpm-instead-of-yarn to develop April 24, 2024 07:25
@github-actions github-actions bot added refactor and removed chore labels Apr 24, 2024
@alexbarnsley
Copy link
Member Author

Downgraded phpdocumentor/reflection-docblock to 5.3 and created an issue in the relevant library that uses the deprecated method: GrahamCampbell/Analyzer#14

@alexbarnsley alexbarnsley marked this pull request as ready for review April 24, 2024 11:27
@ItsANameToo ItsANameToo added this to the 2.26.0 milestone Apr 25, 2024
@ItsANameToo ItsANameToo merged commit ec69200 into develop Apr 25, 2024
9 checks passed
@ItsANameToo ItsANameToo deleted the refactor/migrate-webpack-mix-to-vite branch April 25, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants