Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user balance and balance visibility toggle #961

Merged
merged 55 commits into from
Feb 12, 2025

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Feb 11, 2025

[navbar] add balance visibility

Summary

  • New use-balance-visibility hook to toggle how the user will view balances in the portfolio page (just handled here as the ticket mentions - other pages can be addressed in other tickets).
  • This hook relies on using the DashboardConfig config object from sdk, this can be refactored once we do a cleanup for the config properties.
  • New HideBalance component that contains the button to toggle this hook.
  • Amount and AmountLabel components have been refactored to display **** in case the balance visibility is turned off.
  • New user balance section in the navbar has been added in both mobile and desktop views, also in dark mode.
  • Unit tests and snapshots have been updated to support these changes.
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Feb 12, 2025 3:48pm

@patricio0312rev patricio0312rev merged commit d56277e into feat/evm Feb 12, 2025
17 checks passed
@patricio0312rev patricio0312rev deleted the feat/user-balance-and-hide-values branch February 12, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants