Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove wallet from all networks on user deletion action #965

Merged
merged 4 commits into from
Feb 12, 2025
Merged

fix: remove wallet from all networks on user deletion action #965

merged 4 commits into from
Feb 12, 2025
+8 −3

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Feb 12, 2025

Summary

Closes https://app.clickup.com/t/86dvza7qc

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Feb 12, 2025 2:09pm

samharperpittam
samharperpittam requested changes Feb 12, 2025
View reviewed changes
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works when using the side panel to delete addresses. However, if you do the following, the issue still exists.

  • Import Address
  • Ensure Portfolio view is Single View
  • Use 3dot menu to delete address
  • Try to reimport
  • Error

@samharperpittam samharperpittam marked this pull request as draft February 12, 2025 13:56
@goga-m
Copy link
Contributor Author

goga-m commented Feb 12, 2025

Nice one @samharperpittam. Just patched a fix.

@goga-m goga-m marked this pull request as ready for review February 12, 2025 14:05
@goga-m goga-m added this to the mainsail-evm milestone Feb 12, 2025
@ItsANameToo ItsANameToo merged commit 6861c12 into feat/evm Feb 12, 2025
17 checks passed
@ItsANameToo ItsANameToo deleted the fix/delete-in-all-networks branch February 12, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
mainsail-evm
Development

Successfully merging this pull request may close these issues.
3 participants
@goga-m @ItsANameToo @samharperpittam