Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction sending logic & UI issues #966

Merged
merged 57 commits into from
Feb 14, 2025
Merged

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Feb 12, 2025

Summary

Depends on: #962

Closes: https://app.clickup.com/t/86dvzm6fu

This PR fixes various issues with transaction sending.

  • uses active network from navbar for validator registration/resignation
  • fixes disabled continue button for validator resignation when page loaded with no wallets
  • various UI improvements

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

shahin-hq and others added 30 commits February 6, 2025 20:42
# Conflicts:
#	src/domains/transaction/pages/SendRegistration/SendRegistration.tsx
#	src/domains/transaction/pages/SendValidatorResignation/SendValidatorResignation.tsx
#	src/domains/transaction/pages/SendVote/SendVote.tsx
@ItsANameToo ItsANameToo added this to the mainsail-evm milestone Feb 13, 2025
Base automatically changed from feat/add-username-resignation-tx to feat/evm February 13, 2025 12:14
# Conflicts:
#	src/domains/transaction/pages/SendUsernameResignation/ReviewStep.tsx
@ItsANameToo ItsANameToo merged commit 65a239f into feat/evm Feb 14, 2025
17 checks passed
@ItsANameToo ItsANameToo deleted the fix/tx-sending branch February 14, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants