Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub: add an alt hold mode using the rangefinder #11680

Closed
jaylthegreat opened this issue Jun 28, 2019 · 4 comments
Closed

Sub: add an alt hold mode using the rangefinder #11680

jaylthegreat opened this issue Jun 28, 2019 · 4 comments
Labels
Enhancement For-4.5 Planned for 4.5 release Sub
Milestone

Comments

@jaylthegreat
Copy link
Contributor

jaylthegreat commented Jun 28, 2019

Feature request

Is your feature request related to a problem? Please describe.
Right now, there is just depth hold mode which usually just holds its depth from the surface; however, when a rangefinder is setup and healthy, it will try to maintain that rangefinder distance to the bottom rather than the depth.

Describe the solution you'd like
Maintaining distance from the bottom and maintaining distance from the bottom are totally distinct goals, and, as such, they should be in separate flight modes. I know that support for the rangefinder has been removed while it's being reworked, so this is a suggestion for once that is added back in.

Describe alternatives you've considered
The other solution might be to keep them both in depth hold mode, but then have boolean somewhere that tells the sub which distance to maintain.

Platform
[ ] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover
[ X ] Submarine

Additional context
This page lays out that this intended for depth hold mode.

For context, I've been working on a project and have already implemented it into a separate mode on my fork of the stable branch (I called the mode terrain follow mode) . The more tedious deal (after reworking the rangefinder) is just integrating the new mode with QGC and MavProxy

@rmackay9 rmackay9 changed the title Add an alt hold mode using the rangefinder Sub: add an alt hold mode using the rangefinder Jun 29, 2019
@rmackay9
Copy link
Contributor

As a reference, the way this is handled in copter is the range finder can be disabled using an auxiliary switch

@clydemcqueen
Copy link
Contributor

An implementation: #23435

@Williangalvani Williangalvani added the For-4.5 Planned for 4.5 release label Nov 13, 2023
@Williangalvani Williangalvani added this to the Sub-4.5 milestone Nov 27, 2023
@clydemcqueen
Copy link
Contributor

SURFTRAK is merged, so think we can close this bug. @Williangalvani

@Williangalvani
Copy link
Contributor

Done in #23435

Thanks @clydemcqueen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For-4.5 Planned for 4.5 release Sub
Projects
None yet
Development

No branches or pull requests

4 participants