Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Camera, AP_Mount: Camera Protocol messages don't have component IDs #24955

Open
nexton-winjeel opened this issue Sep 12, 2023 · 1 comment

Comments

@nexton-winjeel
Copy link
Contributor

nexton-winjeel commented Sep 12, 2023

The AP_Camera and AP_Mount libraries have support for some of the messages in the MAVLink Camera Protocol.

However, the handlers for some of these messages (e.g. CAMERA_SETTINGS and CAMERA_INFORMATION) are problematic if there are multiple camera backends:

  • these messages do not have IDs (MAVLink intent is to use compid to distinguish components);
  • the handlers send these messages from each backend with the MAV_COMP_ID_AUTOPILOT1 compid, so they all appear to come from the same component. This will confuse a GCS.

Originally posted by @nexton-winjeel in #24953 (comment)

@rmackay9
Copy link
Contributor

I haven't looked at the details of this particular issue but we hit a similar issue for MAV_CMD_IMAGE_START_CAPTURE and MAV_CMD_IMAGE_STOP_CAPTURE which led to us adding an extension (see PR ArduPilot/mavlink#328)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants