-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to remove or alter auto config for Septentrio GNSS receiver #26070
Comments
Ping @WickedShell , who is responsible for the current logging settings and might have a vested interest in the current settings |
There are a couple of things we can do here, listed in ease of things that already exist:
Regarding the comments made, I'd really prefer the ArduPilot implementation of logging continue to request My builds have been adding the |
I would like to work on this issue. I discussed the implementation with @SeptentrioGNSS and we had the following idea for a more flexible logging implementation. There could be three new parameters added in the Suggested names for the parameters would be The advantage of this approach is that the parameters are detailed enough for users to configure logging how they want, while being generic enough to support different drivers/receivers without adding driver-specific parameters. Any driver-specific things could be documented so users are aware whether their receiver will support the chosen parameter values. I would love any input on this approach. |
@flyingthingsintothings created a PR reflecting his ideas here: #26442 |
Feature request
In the current and latest stable version of the ArduPilot code for the implementation of Septentrio receivers (SBF), there is an auto config for a logged stream to the internal disk of the receiver. The mention of this stream is in the file: AP_GPS_SBF.h. Is there a possibility to make it more configurable for any user to specify if they want this stream logged and what content needs to be logged.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Currently a setSBFOutput command is sent to the receiver. It overwrites configurations made on the receiver side or it might not be needed by the user to have this log and there is no way of removing this from the auto config. As there is no parameters to change the contents of the command this is very limiting as the overwrite happens on every boot of the autopilot. After boot the connected receiver needs to be reprogrammed in order to have the right configurations for a flight.
Describe the solution you'd like
A clear and concise description of what you want to happen.
More customisation could be accomplished by adding 4 variables in MissionPlanner:
With these variables the content of the message sent to the Septentrio receiver can be customised from MissionPlanner itself. The OFF variable assignment would mean no message regarding logging is sent. The variables define the fields needed in the Septentrio command line interface (CLI) command where the interval, the kind of messages logged and an overwrite can be set by the user. The advanced option would allow for an open text field that anny Septentrio command can be sent to the receiver.
Regarding the other fields in the command (e.g. Stream# or Dsk1) it is fine to keep them fixed as I would suggest only making a note which states the usage of the fixed fields in the command so the user is aware of this on the README of the GPSdriver or the .h or .cpp of the SBF code.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Removing the command so that the receiver logging configuration is not touched by MissionPlanner and all the necessary configurations can be made from Septentrio software tools but this adds a level of extra work as not everything can be done from MissionPlanner itself. The preferred solution is the one above as this incorporates a mostly all-in-one solution for integrations of ArduPilot and Septentrio GNSS receivers.
Platform
[ X ] All
[ ] AntennaTracker
[ X ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine
Additional context
Add any other context or screenshots about the feature request here.
code in question is at line 87
The text was updated successfully, but these errors were encountered: