Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#26740 causes old params to appear on Wiki param pages #27929

Closed
Hwurzburg opened this issue Aug 26, 2024 · 4 comments
Closed

#26740 causes old params to appear on Wiki param pages #27929

Hwurzburg opened this issue Aug 26, 2024 · 4 comments

Comments

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Aug 26, 2024

PR #26740 has caused a user(I expect more) to raise wiki issue stating the wiki pages are not using the correct params, since both the old and new names are shown in the emitted parameter pages...we have not done this for previous param renames...either we show the old names somehow differentiated in the wiki param page or we should revert this....I dont see how NOT doing this was a "breaking" change to older firmware as PeterB told me...

@rmackay9
Copy link
Contributor

I've slightly modified the description of this issue to include the link to the PR in question #26740

@IamPete1
Copy link
Member

We have tried to do this where we remember. The problem is that Mission planner uses the master param descriptions, so we were getting issues that the param descriptions where not there for GPS. For example (#26681)

I think having too many params is better than having too few, until we fix the GCS side I'm not sure how we can do it better.

@Hwurzburg
Copy link
Collaborator Author

Hwurzburg commented Aug 26, 2024

can we add a note in the param metadata to warn that the param is renamed as of version x.x?

see #27993

@peterbarker
Copy link
Contributor

Was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants