AP_Camera: CAMERA_FOV_STATUS includes horizontal and vertical field-of-view #25441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khancyr
approved these changes
Nov 2, 2023
peterbarker
approved these changes
Nov 2, 2023
|
Ah right, so the HFOV range should probably be 0 to 360 and VFOV should be 0 to 180? This PR is pretty new so I'm happy to fix it now. |
|
I've updated the HFOV and VFOV parameter ranges to be 0 to 360 and 0 to 180 respectively. Txs the feedback, I might merge after this passes CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change built on top of PR #25390 populates the hfov and vfov fields in the CAMERA_FOV_STATUS message with values from two new CAMx_HFOV and CAMx_VFOV parameters.
This has been lightly tested in SITL and below are screen shots showing the two fields are populated.
