Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up basic infrastructure for running a CLI smoke test #1

Closed
6 tasks done
Ryanf55 opened this issue Mar 22, 2023 · 2 comments
Closed
6 tasks done

Set up basic infrastructure for running a CLI smoke test #1

Ryanf55 opened this issue Mar 22, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Mar 22, 2023

Create a ROS2 package that can run a smoke test to ensure the DDS functionality in ardupilot is working as intended.

  • Can be build with colcon build
  • Can be tested with colcon test
  • A failure to receive any messages results in failure
  • A failure to receive messages within the expected rate results in failure
  • A failure to receive the Time topic with the time close to epoch() results in failure
  • A failure for the node to start results in failure

References:
https://github.com/ros2/launch_ros/pull/263/files#diff-9d860a3041f103f8e08aef7ce1db4364a4a7048ee6afaadd3c4e820647786e45

https://github.com/GitRepJo/ros2_cpp_test_example/blob/main/test/sub_pub_launch_testing.py

ros2/launch_ros#272

@Ryanf55 Ryanf55 moved this to 🆕 New in DDS/ROS2 Mar 22, 2023
@Ryanf55 Ryanf55 added this to DDS/ROS2 Mar 22, 2023
@Ryanf55 Ryanf55 added the enhancement New feature or request label Mar 22, 2023
@Ryanf55 Ryanf55 moved this from 🆕 New to 📋 Backlog in DDS/ROS2 Mar 22, 2023
@Ryanf55 Ryanf55 moved this from 📋 Backlog to 🔖 Ready in DDS/ROS2 Apr 5, 2023
@srmainwaring
Copy link
Collaborator

srmainwaring commented Apr 6, 2023

Basic CLI smoke tests will probably go into the main ArduPilot repo. Development is on this branch: https://github.com/srmainwaring/ardupilot/tree/wip/ros2-pkg-cmake-v2.

Status

Items to resolve

ROS testing framework

There are multiple packages for testing launch with varying degrees of usage in ROS Humble and integration with colcon.

  • launch
  • launch_testing
  • launch_pytest
  • launch_ros
  • launch_testing_ros
  • ros2launch

Some guidance here: https://answers.ros.org/question/325167/difference-between-launch-and-launch_ros/, but examples and documentation are sparse.

Process clean up

  • Ensure processes clean up on test exit (both success and failure). e.g. socat.

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented May 5, 2023

Closed by #23429

@Ryanf55 Ryanf55 closed this as completed May 5, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in DDS/ROS2 May 5, 2023
srmainwaring added a commit that referenced this issue May 7, 2023
* Launch Iris: initial version of ardupilot_gz

- Adapted from https://github.com/gazebosim/ros_gz_project_template.
- Change project names.
- Update dependencies.
- Update README.
- Update launch for macOS (separate server and gui for Gazebo).
- Update maintainer details.

Signed-off-by: Rhys Mainwaring <[email protected]>

* Launch Iris: rename diff drive bridge yaml, remove extra clock entry

Signed-off-by: Rhys Mainwaring <[email protected]>

* Launch Iris: add bringup for iris quadcopter

- Shorten name in interface to iris.

Signed-off-by: Rhys Mainwaring <[email protected]>

* Launch Iris: add lift-drag and ardupilot plugins to example

Signed-off-by: Rhys Mainwaring <[email protected]>

* Launch Iris: enable static code checks

- Enable static code checks in ardupilot_gz_gazebo

- Enable static code checks in ardupilot_gz_description
  - Run all common linters.

- Enable static code checks in ardupilot_gz_bringup
  - Apply flake8 extend-ignore.
  - Format launch files with black.
  - Apply common linters.

Enable static code checks in ardupilot_gz_application

Signed-off-by: Rhys Mainwaring <[email protected]>

* Launch Iris: add iris bringup launch

- Compose the SITL and microROS agent launch with Gazebo and Rviz.

Signed-off-by: Rhys Mainwaring <[email protected]>

* Launch Iris: update README

Signed-off-by: Rhys Mainwaring <[email protected]>

* Launch Iris: move projects up to main directory

Signed-off-by: Rhys Mainwaring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants