Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: add AM32 page #6403

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Common: add AM32 page #6403

merged 1 commit into from
Nov 23, 2024

Conversation

rmackay9
Copy link
Contributor

This adds an AM32 ESC wiki page. I've seen at least one support call on the forums asking about AM32 ESCs so I hope this will give users at least an idea of the state of affairs which is perhaps simply that there aren't many AM32 ESCs that support DroneCAN (yet)

I've built this locally and it looks OK to me

@@ -47,6 +47,7 @@ Protocols
DShot ESCs <common-dshot-escs>
KDE CAN ESCs <common-kde-can-escs>
DroneCAN ESCs <common-uavcan-escs>
AM32 ESCs <common-am32-escs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is by protocol type...AM32 ESCs are both std (PWM,Dshot) and DroneCAN....I would move this to under the DroneCAN ESCs topic....users searching the wiki for AM32 will find it

Copy link
Contributor Author

@rmackay9 rmackay9 Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hwurzburg

I've linked it from both the higher level "ESCs and Motors" and the "DroneCAN ESCs" page. This is the same as for the Currawong and Hobbywing DroneCAN ESCs which are also in both places.

I'd like to give the AM32 ESCs a high profile because it's open source and we (or at least Tridge) is involved with their development

Also the AM32 is really a particular software so underneath AM32 we end up with many different manufacturers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep things moving along I'm going to remove the link from the top level Motors and ESCs page.. but I need to add the page to a Toc tree somewhere..

@rmackay9 rmackay9 merged commit de6d0ba into ArduPilot:master Nov 23, 2024
5 checks passed
@rmackay9
Copy link
Contributor Author

After a discussion with HenryW we decided to merge as-is and then fix it

@rmackay9 rmackay9 deleted the am32 branch November 23, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants