Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: laravel 10 compatibility #614

Merged
merged 9 commits into from
Mar 25, 2024
Merged

refactor: laravel 10 compatibility #614

merged 9 commits into from
Mar 25, 2024

Conversation

alfonsobries
Copy link
Member

Summary

Related to https://app.clickup.com/t/86dt0evu0

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo
Copy link
Member

@alfonsobries have a look at the tests, they get stuck and a lot of them are failing

@ItsANameToo ItsANameToo changed the title refactor: make it compatible with laravel 10 refactor: laravel 10 compatibility Mar 25, 2024
@ItsANameToo ItsANameToo merged commit d798c7c into main Mar 25, 2024
6 checks passed
@ItsANameToo ItsANameToo deleted the refactor/laravel-11 branch March 25, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants