Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle overriding currency decimal places #624

Closed

Conversation

alexbarnsley
Copy link
Member

Summary

related to https://app.clickup.com/t/86dugrp91

Mainsail will handle 18 decimal places instead of 8, so this is to allow changing that while also remaining backwards compatible

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley
Copy link
Member Author

I'm happy to close this as I don't believe it's required. Everywhere it's used we pass in a decimal value. The only time it doesn't is when using the <x-currency component, but that can also be overridden in the component if we need to do so.

@ItsANameToo it won't cause issues if it's merged, but I'll leave it up to you :oleglala:

@ItsANameToo
Copy link
Member

closing for now, can be added once we need it for something

@ItsANameToo ItsANameToo closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants